Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Candidate: 2020-05-27 #96

Merged
merged 10 commits into from
Jun 11, 2020
Merged

Integration Candidate: 2020-05-27 #96

merged 10 commits into from
Jun 11, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jun 3, 2020 •
edited
Loading

Describe the contribution
Fix #92

and combines

  1. Integration Candidate: 2020-05-27 cFE#729
  2. Integration Candidate: 2020-05-27 osal#487
  3. Integration Candidate: 2020-05-27 PSP#167
  4. Integration Candidate: 2020-05-27 ci_lab#50
  5. Integration Candidate: 2020-05-27 sample_app#71
  6. Integration Candidate: 2020-05-27 to_lab#44
  7. Integration Candidate: 2020-05-27 cFS-GroundSystem#101

Testing performed
https://github.com/nasa/cFS/pull/96/checks

Expected behavior changes
See submodule pull requests

PR #94 - lgtm analysis ignores Ui_* files from cFS-GroundSystem

System(s) tested on
Ubuntu:Bionic

Additional context
None

Contributor Info - All information REQUIRED for consideration of pull request
PR #94 - Leor Bleier, NASA-GSFC
See submodules for other contributors

@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request fixes 7 alerts when merging 64fe4c1 into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request fixes 7 alerts when merging 6dd632a into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

This was referenced Jun 8, 2020
Merged
Merged
@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request fixes 7 alerts when merging f3b303a into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request fixes 7 alerts when merging 2e60b4c into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request fixes 7 alerts when merging 8c83a0f into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

This was referenced Jun 8, 2020
Merged
Merged
Merged
Merged
Merged
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2020

This pull request fixes 7 alerts when merging 8d1c4db into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2020

This pull request fixes 7 alerts when merging 6730497 into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@skliper
Copy link
Contributor

skliper commented Jun 10, 2020

The sample_app test hardcodes checking the version string... probably better to just check format (not the actual value).

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2020

This pull request fixes 7 alerts when merging 84a95e1 into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2020

This pull request fixes 7 alerts when merging 2b180f5 into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@astrogeco astrogeco marked this pull request as ready for review June 11, 2020 01:11
@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2020

This pull request fixes 7 alerts when merging 0b3c934 into d80daf5 - view on LGTM.com

fixed alerts:

  • 6 for Local variable hides global variable
  • 1 for Missing header guard

@astrogeco astrogeco merged commit da695db into master Jun 11, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
@jphickey
Fix nasa#96, remove unused CF_EndOfHeaderPtr function
3d600e8 
Unused functions/dead code should not be included in FSW
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
@astrogeco
Merge pull request nasa#97 from jphickey/fix-96-unused-endofhdrptr
1a87299 
Fix nasa#96, remove unused CF_EndOfHeaderPtr function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lgtm.yml to exclude Ui files
3 participants
@astrogeco @skliper @lbleier-GSFC